[squid-dev] [PATCH] Bug 4111 fix

[Alex Rousskov]

On 02/16/2016 05:05 PM, Amos Jeffries wrote:
> This bug had unfortunately gotten lost in the flood. The bug reporters
> proposed patch seems to be correct in terms of its intention.
> 
> This version of the patch adds the missing {} and uses fatalf() instead
> of exit(). It also goes a little further and corrects the outstanding
> errno handling issues in the affected functions. Both of these
> diffferences are to ensure consistent error reporting on the abort.

This will probably break many misconfigured but "working fine" Squids
that currently display the error message and proceed. I have seen a few
such ignored messages in deployment logs. This does not mean we should
not fix this bug, of course. A prominent change/release log mention is
probably warranted though.

You should probably add "const" to all the new "auto"s.


Thank you,

Alex.