[squid-dev] [PATCH] implement RFC3986

[Alex Rousskov]

On 02/13/2016 01:47 AM, Amos Jeffries wrote:
> On 11/02/2016 5:27 a.m., Alex Rousskov wrote:
>> On 02/10/2016 08:59 AM, Amos Jeffries wrote:
>>> This is the updated patch implementing RFC 3986 URI coding ('URL-escaping').
>>>
>>> So far all the audit suggestions except Tokenizer usage have been
>>> implemented. Tokenizer is omitted because we still want helpers to be
>>> able to instantiate these templates functions with std::string.
>>
>> I do not think "we" want these templates. If helper code prefers to use
>> std::string, that code can call a simple wrapper that converts
>> std::string to SBuf or Tokenizer and then calls the non-template Rfc3986
>> functions.


> What is the big problem with these generic template functions?

I believe the problem has already been discussed. I have no new general
information to add to that discussion, but would be happy to try to
answer any specific questions.

Alex.