[squid-dev] [PATCH] convenience library renaming

[Alex Rousskov]

On 02/09/2016 01:57 AM, Amos Jeffries wrote:
> On 9/02/2016 10:08 a.m., Alex Rousskov wrote:
>> On 02/08/2016 01:41 PM, Amos Jeffries wrote:
>>> I have been trying to automate graphing of the Squid internal
>>> dependencies. One of the major issues that has encountered is that some
>>> of our convenience libraries use the '-' hyphen character which is a
>>> reserved character in DOT graph format.
>>>
>>> To make the scripts much simpler and the visual output reflect exactly
>>> what the library names this patch cleans up the library names to follow
>>> our pre-existing policy, and now also to remove punctuation from the
>>> library names.
>>
>> No objections. The library names look inconsistent to me so if you are
>> changing them, you may also want to switch to a single name format:
>> "libX.la", "libsquidX.la", or "libsquid_X.la".

> Uhm. I did.

You did not switch to a single name format.


> This patch is changing those to X/libX.la wherever possible. But leaving
> X/libXsquid.la as the exception

... which results in an inconsistent look-and-feel. If you were trying
to make things look consistent, why pick the format that requires
exceptions?

Alex.