[squid-dev] [PATCH] SBuf const iterator fixes

Kinkie gkinkie at gmail.com
Mon Feb 8 19:29:55 UTC 2016


+1; please merge asap.

On Mon, Feb 8, 2016 at 7:18 PM, Amos Jeffries <squid3 at treenet.co.nz> wrote:
> The SBufIterator is mostly actually a const iterator. But not quite.
>
> The point of difference from const_iterator is the operator*() API which
> is also different from the normal itertor API in that is returns a char
> instead of a char& or const char &.
>
> The attached patch fixes that API making the iterator equivalent to
> const_iterator for the subset of iterator API that it does present.
>
> This has side effects on the reverse iterator and SBuf begin/end
> methods. Which are also const'ified.
>
> There appears to be no built-time or unit test identified problems from
> this change. IT passes the build farm QA easily.
>
> Are there any objections to fast-tracking this merge? If not I hope to
> apply this in the next day or two.
>
> Amos
>
> _______________________________________________
> squid-dev mailing list
> squid-dev at lists.squid-cache.org
> http://lists.squid-cache.org/listinfo/squid-dev
>



-- 
    Francesco


More information about the squid-dev mailing list