[squid-dev] [PATCH] Compilation fix for v5 r14973

[Amos Jeffries]

On 11/12/2016 10:35 p.m., Eduard Bagdasaryan wrote:
> Attached a patch witch removes SquidConfig  dependency
> on vector<SchemesConfigs> and uses vector<SchemesConfigs> *.
> instead. This fixes pinger linking error.
> 
> 
> Eduard.
> 

Here is an alternative that fits better (but not completely) with the
HotConf project goals.

Specifically the change is to move the auth specific config object into
Auth:: namespace scope insead of placing it within SquidConfig.

I have not in this patch refactored the existing Auth::Config to contain
both auth_params and auth_schemes data. This is just a quick shuffle to
fix the current link errors.

I'm not sure which is better performance wise.

Alex: Care to make the call between one of these two patches or wait a
day or so more for the full refactor ?

Amos


> On 10.12.2016 23:55, Amos Jeffries wrote:
>> On 11/12/2016 6:12 a.m., Christos Tsantilas wrote:
>>> I applied the patch, however still exist problem. The icmp pinger does
>>> not build correctly.
>>> We should add libsbuf library to pinger libraries, but still there are
>>> references to HistStat.cc file (maybe add HistStat stub files for
>>> pinger?).
>> pinger does not use the Auth:: things, so it really should not pull them
>> + dependencies in.
>>
>> The correct fix I think is to refactor the Auth::Config so that the
>> various global auth* directives can all be stored there. I'm working on
>> that right now.
>>
>> Amos
>>
>> _______________________________________________
>> squid-dev mailing list
>> squid-dev at lists.squid-cache.org
>> http://lists.squid-cache.org/listinfo/squid-dev
> 
> 
> 
> _______________________________________________
> squid-dev mailing list
> squid-dev at lists.squid-cache.org
> http://lists.squid-cache.org/listinfo/squid-dev
>