[squid-dev] [PATCH] Incorrect processing of long URIs

[Eduard Bagdasaryan]

2016-08-23 3:08 GMT+03:00 Alex Rousskov <rousskov at measurement-factory.com>:

 > I do not understand why you decided to use maxMethodLength in
 > parseRequestFirstLine(). AFAICT, parseMethodField() already does
 > everything we need: It logs an error message and sets parseStatusCode
 > accordingly.

Yes, it does partly what we need but it does not parse the delimiter(
and inform about possible failure). skipDelimiter() does this with
message:

 > invalid request-line: missing delimiter

which does not hint that our case is a 'bad' method and
less informative than:

 > invalid request-line: method exceeds 32-byte limit

Probably this does not make much sense, so I followed your
sketch and refreshed the patch.


Eduard.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: SQUID-169-incorrect-processing-of-long-uris-t4.patch
Type: text/x-patch
Size: 5473 bytes
Desc: not available
URL: <http://lists.squid-cache.org/pipermail/squid-dev/attachments/20160823/f1021ec0/attachment.bin>