[squid-dev] [PATCH] Make Squid death due to overloaded helpers optional

[Eduard Bagdasaryan]

2016-08-08 23:17 GMT+03:00 Amos Jeffries <squid3 at treenet.co.nz>:

 > s/temporary exceed/temporarily exceed/

Done.

 > please remove the above/below wording.

Removed.

 > the lines documenting 'die' and 'err' action look a bit squashed up.

Adjusted accordingly.

 > looks wrong documentation for the overloaded() method

Removed that comment at all, since the method looks simple and
self-documented.

 > please revert to sending helper::Unknown code

Reverted. Note that for helper::Unknown some callers print a bit
misleading error message, when requests are dropped, e.g.:
"ERROR: storeID helper returned invalid result code. Wrong helper?"

 > Also, can we please add a "wait" action as well. Which means just keep
 > queueing things and ignore the overload.

I don't think we need this extra option. Currently we have a hard-coded
3 min. timeout, within which requests are keep queuing ignoring
[possible] overload. Probably you need another option to configure this
timeout? That would be a separate task, IMO.



Eduard.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: SQUID-30-reject-helper-requests-on-overload-t11.patch
Type: text/x-patch
Size: 52986 bytes
Desc: not available
URL: <http://lists.squid-cache.org/pipermail/squid-dev/attachments/20160809/a097d107/attachment-0001.bin>