[squid-dev] [PATCH] Ipc::MemMap::ttl removal

Amos Jeffries squid3 at treenet.co.nz
Mon Aug 8 23:22:46 UTC 2016


On 9/08/2016 11:09 a.m., Alex Rousskov wrote:
> On 08/08/2016 08:12 AM, Amos Jeffries wrote:
>> Coverity Scan latest checks are reporting that the ttl member of
>> Ipc::MemMap is being left uninitialized.
>>
>> It sounds like something which would lead to major bugs. Except that it
>> turns out, AFAICS, that this ttl member is never actually being used.
>>
>> Anyone have a reason not to simply drop it from the code?
> 
> There cannot be valid reasons to keep unused code for more than a year.
> Please remove it.
> 
> FWIW, I bet it is just accidental leftovers from some earlier MemMap design.
> 
> Alex.
> 

Thanks. Applied as trunk rev.14781.

Amos



More information about the squid-dev mailing list