[squid-dev] [PATCH] GnuTLS session redo

[Alex Rousskov]

On 08/04/2016 03:40 AM, Amos Jeffries wrote:
> On 4/08/2016 5:57 p.m., Amos Jeffries wrote:

> I'm also wondering if it would be useful to add debugs() in the Get/Set
> functions for debugging session resume usage.

If we do not have that already, I think it would be very useful to add
debugging that shows whether the session was reused (and if not reused,
why). Whether that debugging should go into those Get/Set functions, I
have not checked. If those functions are called once per connection,
then they may be good candidates.


> Would it be worth the performance hit?

Is there a performance hit associated with adding a few debugs()
statements that will be checked once or twice per SSL connection!?


>  if so, at what debug level?

Just a suggestion:

3 for not reusing for some non-trivial reason
3 for failing to prepare future reuse for some non-trivial reason
5 for reusing (once per connection?)
5 for successfully preparing future reuse
7 for all the trivial cases and everything else


HTH,

Alex.