[squid-dev] [PATCH] Remove ServerOptions "partial copy" copy constructor

[Alex Rousskov]

On 04/07/2016 03:22 AM, Amos Jeffries wrote:
> On 7/04/2016 6:10 p.m., Alex Rousskov wrote:
>>     The attached patch removes broken and, AFAICT, unused "partial copy"
>> ServerOptions copy constructor.


> A (full) copy-constructor is needed on some systems for the clear()
> method implementation to build.


AFAICT, the clear() method needs an assignment operator rather than a
copy constructor. Prohibiting copy construction with "= delete" has no
effect on the compilation (with GCC v4). The code without manual copy
constructor builds with clang as well.

Is there something wrong with the full copy constructor generated by
default?

Can you share more information about what happens when there is no
manual copy constructor and which systems are affected?


Thank you,

Alex.