[squid-dev] [PATCH] Fix for bug 4190

[Amos Jeffries]

On 28/09/2015 12:56 p.m., Amos Jeffries wrote:
> New patch attached. I believe is resolves all the issues brought up so
> far and a few clang build issues I found during the re-work.
> 
> 
> The changes since previous iteration are:
> 
> * rename to CredentialsCache
> 
> * split Cache and Runner into two objects. Creating a Cache spawns a
> Runner dedicated to managing it through a Pointer held by the Runner.
> 
> * made the cache key a value passed in by the caller code. For storing
> credentials by arbitrary token/format/scope value rather than just username.
> 
> * removed the explicit eventDelete(), and using eventAdd() only when
> data exists in the cache to be cleaned up.
> 
> 
> Despite the long description of changes the actual logic difference is
> quite small.
> 
> So, if there are no objections I would like to merge this in the next
> day or two.
> 

Ping. Make that about this time tomorrow.

Alex: if you left a hold message in IRC I have not seen it, but knotter
was down.

Amos