[squid-dev] [PATCH] keep track of the size of uploads done with CONNECT

[Alex Rousskov]

On 09/14/2015 12:32 PM, Aymeric Vincent wrote:

> could you please consider the attached patch for inclusion in squid's
> trunk? 

> +    int64_t in_size;    /* size of payload uploaded through a tunnel */


You are adding a new ClientHttpRequest in_size field dedicated to
client-sent "payload" sizes in tunnels, but Squid seems to be using
AccessLogEntry's http.clientRequestSz.payloadData for similar purposes
in non-tunnel areas of the code. Would it be possible to teach tunnel.cc
code to update http.clientRequestSz.payloadData (directly or indirectly)
instead of adding a new field?


Thank you,

Alex.



> A hopefully suitable commit message follows. Please feel free to
> improve and commit the patch at your convenience.
> 
> Regards,
>  Aymeric
> 
> Use the functionality of TunnelState's client and server fields to
> account for the upload side of a tunnel, not just download.
> Also, simplify tunnelStart()'s prototype because all callers pass a
> pointer to the same subfield of an instance it gets as a parameter
> anyway, and we need two such pointers now which are still part of the
> same instance.
> 
> 
> 
> _______________________________________________
> squid-dev mailing list
> squid-dev at lists.squid-cache.org
> http://lists.squid-cache.org/listinfo/squid-dev
>