[squid-dev] [PATCH] %<lp missing for persistent connections

[Alex Rousskov]

On 10/21/2015 03:14 AM, Amos Jeffries wrote:
> On 21/10/2015 4:42 p.m., Alex Rousskov wrote:
>> Hello,
>>
>>     Connection stats, including %<lp, were missing for persistent
>> connections.
>>
>> The code reusing a pconn was missing a hier.note() call, resulting in 0
>> values logged for %<lp (local port number of the last server or peer
>> connection) and probably other missing stats.
>>
>> Also refactored poorly copied statistics collection code to remove
>> duplication and always update to-server connection stats when the actual
>> connection becomes available.
>>
>> Positive side effect: Upon setsockopt(2) failures, the tos and nfmark
>> fields of a pinned connection were set to the desired (but not actually
>> applied) values, while persistent connection fields were left intact
>> (and, hence, stale). Both fields are now reset to zero on failures, for
>> both types of connections.
>>
> 
> +1.

Committed to trunk (r14367).


Thank you,

Alex.