[squid-dev] [PATCH] SBuf case-change operations are safe against OutOfBoundsEception

[Kinkie]

Hi,
  I'd like some feedback on this patch. Coverity detects an uncaught
exception code path for OutOfBoundsException which eventually leads to
SBuf.toUpper. However in single-threaded mode the exception cannot be
thrown by the loop calling that code.
Is it reasonable to explicitly catch that exception as I do in the attached
patch or should we rather triage and mark as false positives in coverity
all uses of this method? Or is there a more effective way to obtain the
same result?

Thanks

-- 
    kinkie
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squid-cache.org/pipermail/squid-dev/attachments/20150627/ae2d61aa/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sbuf-changecase-exceptionsafe.patch
Type: text/x-patch
Size: 1167 bytes
Desc: not available
URL: <http://lists.squid-cache.org/pipermail/squid-dev/attachments/20150627/ae2d61aa/attachment.bin>