[squid-dev] Bug fixes for mingw based on squid-3.5.0.4-20150106-r13714

[Amos Jeffries]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 13/01/2015 8:09 a.m., Dennis wrote:
> 
> Dear Sirs
> 
> I tried compiling squid-3.5.0.4-20150106-r13714 running under
> windows with wingw

Hi Dennis, thank you!

> 
> It still had a few bugs. I fixed them and now it compiles and runs,
> but still can't resolve addresses (I have correctly specified the
> name servers). I get: WARNING: Reply from unknown nameserver
> [::]:53
> 
> I don't have more time to work it further.
> 
> I would like to contribute with the fixes I wrote. Here are them.
> 
> Obs.: the diff shows squid-3.5.0.4 against 
> squid-3.5.0.4-20150106-r13714, but it is actually my 
> squid-3.5.0.4-20150106-r13714 against
> squid-3.5.0.4-20150106-r13714
> 
> configure command used: ./configure --enable-default-hostsfile=none
> --prefix=C:/msys/1.0/squid mingw version: latest 32 bit.

MinGW32 32-bit ? or MinGW-w64 32-bit ?
I am finding there are some critical API differences between the two
"MinGW" projects.

> 
> diffs:
> 

Can you present these in unified format please? (diff -ur ...), and
attachments rather than inline.
It's very hard to read the other format around email quoting.

> 
> diff -r C:\msys\1.0\var\squid-3.5.0.4\compat\os\mswindows.h 
> C:\msys\1.0\var\squid-3.5.0.4-20150106-r13714\compat\os\mswindows.h
>
> 
625,630c624,629
> < /* commen out this function < inline char * < inet_ntop(int af,
> const void *src, char *dst, size_t size) < { <     return
> (char*)InetNtopA(af, const_cast<void*>(src), dst, size); < } <
> #define inet_ntop(a,s,d,l) Squid::inet_ntop(a,s,d,l) */ ---
>> inline char * inet_ntop(int af, const void *src, char *dst,
>> size_t size) { return (char*)InetNtopA(af,
>> const_cast<void*>(src), dst, size); } #define inet_ntop(a,s,d,l)
>> Squid::inet_ntop(a,s,d,l)
> 

FYI: A fix for the re-definition error is about to be backported. But
the absence of InetNtopA API call required by MS is still an issue I'm
working on now.

Amos
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (MingW32)

iQEcBAEBAgAGBQJUtIdUAAoJELJo5wb/XPRjREIIAMx0UgbcS3lw8N2vFbuYhOt3
J4s/+UVXJ4up5iq3MHtXKDK2tvDo3Bln9ZdAbUnXlrBdIZomDFMLfbU+6aToVFrL
ACrmvJCFdoyBfjaSr1WONyf8mEifLfI/20gJWq5fRKw0OEiTNujfqTOvF+OBcLez
JIkcMgjyhiwT3CITytXmVuFQxYzX/IAUQTHkf5axWUISyPbOIKFQ0lznMEaKHvC6
tMklOnzDY3pIGYNi5tYKR76qs5vfuiCtxWWVMRt9976ABCViz5xatJyYO2d8Msrx
FXmtjgie9rmX/AKkmffSTw9mW3Ls6J4/yF9G9YMa3ZSX5Yjf0G2OCeJHHjJIqTM=
=hxHP
-----END PGP SIGNATURE-----