[squid-dev] [MERGE] Fix splay

[Amos Jeffries]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 3/01/2015 1:54 a.m., Kinkie wrote:
>> I believe this is missing several "delete Foo;" in the ACL 
>> destructors. You used new() to allocate the Splay<> objects,
>> there should be matching delete() at the same owner/abstraction
>> level. For example: " ACLIP::~ACLIP() { if (data) { 
>> data->destroy(IPSplay::DefaultFree); data->destroy(); delete
>> data; } } " ... although, it would be even better if the data
>> members could be made non-pointers now they are Splay<> objects.
>> Is that easy enough to do in this patch ?
> 
> Well, splay doesn't have a destructor :\ I'll see if I can do
> something about it.
> 
>> Other than the new() / delete() issue. +1.
> 
> Ok, thanks. I'll also see about the empty lines.
> 

For the record this was merged as trunk rev.13810.

Amos
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (MingW32)

iQEcBAEBAgAGBQJUq1wFAAoJELJo5wb/XPRjjcIIAI1DKgOnGgX+l5HQXsc6YK2J
ALTV1FryIfE0v179uSy2RshWuq3VdgDbVBHQmHjLhcEtK2wJVNHBWzML7Bqfpdn8
O5ayKRqsjg5nhSsgr0NbaGhivK/JCM5vO3Q4vejFQp2Oy3geZOBvZfntFoUBp1xu
o2P5ZzgFU1sQ9LoM5WoCjfWwfb7BOrKbwkEX/BzK0v9iOx9b3U6dpOtCKT11EDTg
MW9x0UVjAC/TVRY9bXiBAEUHG4TPPIa5Syrx9bIqobA8u2UTLd36TQqNdfJDz3jP
sVGN6B/p6W4gbEsTJnqfP7YEXmhb+gMvCYNdNvlhS7152APdi8+TNNJkSaqWGQQ=
=buZA
-----END PGP SIGNATURE-----