[squid-dev] [MERGE] Fix splay

[Kinkie]

Hi,
  splay uses lots of C-isms still, which make recent clang fail the build badly.

Things like:
SplayNode<foo> *root = NULL
root->insert(data)

The attached patch :
- migrates all clients from using the now-private SplayNode API to Splay
- fixes Splay to account for some corner-cases
- removes always-true or always-false conditionals in SplayNode (if
(this == NULL))
- ports parts of the unit test (most were not ported assuming the aim
is to test the private API)

This builds and checks fine on ubuntu utopic with gcc and clang (clang
halts the build on a similar issue in src/comm/Read.cc but that's
another topic).

Public branch is at lp:~squid/squid/splayfix

To me this is a reasonable merge candidate; please review.

Thanks

-- 
    Francesco
-------------- next part --------------
A non-text attachment was scrubbed...
Name: splayfix-v1.patch
Type: text/x-diff
Size: 49876 bytes
Desc: not available
URL: <http://lists.squid-cache.org/pipermail/squid-dev/attachments/20150102/8e6bed11/attachment-0001.patch>