[squid-dev] [PATCH] ICAP read buffer SBuf conversion

[Amos Jeffries]

On 28/02/2015 5:15 p.m., Amos Jeffries wrote:
> Contains three changes required before we can upgrade the ICAP message
> parser:
> 
> * Convert the ICAP read buffer to an SBuf.
> 
> * Remove the double-buffering hack used to comm_read() ICAP responses as
> c-string then convert to MemBuf for parsing.
> 
> * Revert the HttpMsg parser API from MemBuf to c-string parameters.
> The internals did not make much use of the MemBuf abilities and it is
> simpler to retrieve c-string values directly from an SBuf than to go via
> a MemBuf conversion.
> 
> I am seeking help testing that the ICAP I/O is still operational. If
> anyone has ICAP services and is willing to run a trunk/3.HEAD proxy with
> this patch applied please do.

It seems to work for me with c-icap echo service, but still looking for
confirmation.

Amos