[squid-dev] [PATCH] Crypto-NG: update use of random number generators

[Kinkie]

one more item for the todo list ;)

On Wed, Feb 11, 2015 at 1:00 AM, Amos Jeffries <squid3 at treenet.co.nz> wrote:
> On 9/02/2015 6:23 a.m., Kinkie wrote:
>> Hi.
>>    I suggest using uint16_t instead of unsigned short int and related
>> macros for clarity (see
>> http://en.cppreference.com/w/cpp/types/integer).
>> I can find no other obvious issues; so if the above is covered it's +1
>> from me without re-review.
>
> Are you taking about the use of short in dns_internal.cc ?
>
> I agree that it is not a great type, however its the one which the ID
> objects are using all throught the DNS logics. I'm only changing the
> random generator itself in this patch, the types are mostly out of scope
> and that one in particular is so widely used it would be a cleanup patch
> all by itself
>
> Amos
>



-- 
    Francesco