[squid-dev] [PATCH] SBuf iterators

Amos Jeffries squid3 at treenet.co.nz
Sun Feb 1 05:59:31 UTC 2015


On 1/02/2015 8:47 a.m., Kinkie wrote:
> Hi,
>   attached is a patch implementing forward and reverse input iterators for SBuf.
> It's meant to be used together with the upcoming CompactTrie to
> implement zero-copy efficient prefix (and suffix) matching.
> Please review.
> 

I think you are right about the SBuf comparison being unnecessary, which
bring into question why the iterators are storing an SBuf reference at all.

If we are going to have any validity checks then its necessary to check
iter against the SBuf values. But otherwise unneeded.

Amos



More information about the squid-dev mailing list