[squid-dev] [PATCH] C++-ify basic_fake_auth

Kinkie gkinkie at gmail.com
Mon Dec 21 10:23:21 UTC 2015


On Wed, Dec 16, 2015 at 10:30 PM, Amos Jeffries <squid3 at treenet.co.nz> wrote:
> On 17/12/2015 4:32 a.m., Kinkie wrote:
>> Hi,
>>    the attached patch completes the c++-ification of basic_fake_auth.
>>
>
> Well, I would not call this completed. The full plan for helpers
> involves providing a library that does the main() and Squid I/O portions
> - so the helper logic just implements a child class API.
>
>
> Does this build with all helpers?
>  helpers/defines.h is included widely.
>
>
> If (and only if) so, +1.

Hi,
 yes, it does - in fact it's being build-tested in the same conditions as trunk.

One key difference: it doesn't explicitly set unbuffered output, but
relies on the (standard-mandated) behavior of std::endl to flush
buffers.

Merged as r14454.


-- 
    Francesco


More information about the squid-dev mailing list