[squid-dev] [PATCH] Coverity-fixes, part 1: EnumIterator

[Alex Rousskov]

On 08/27/2015 03:04 AM, Kinkie wrote:

>     >     >> + *   zeroth, first, second, onePastLast, fourth
>     >     Please make onePastLast last.
> 
> 
>     > I'm trying to highlight the fact that
>     > the dereferencing will only happen on EnumType::first and
>     > EnumType::second. Any suggestion on how to clearly express it is welcome.
> 
>     1. Replace the current enum values with five color names: white, blue,
>     red, orange, pink.
> 
>     2. Iterate from blue to orange.
> 
>     3. Add a do_stuff(v) call comment saying that it will be called with red
>     and blue values only.


> Done


Not as far as I can see:


> + * Typical use:
> + * \code
> + * enum class EnumType {
> + *   zeroth, first, second, onePastLast, fourth
> + * };


This is why I continue to strongly discourage folks from posting "Done"
responses without actual patches. It is often worse than not posting a
response at all because the reviewer has to remember to go back to some
old email and check whether some old Done was really done. Done should
mean "done in the attached or committed patch".

Alex.