[squid-dev] [PATCH] detect compiler support for c++11 "override" keyword

[Kinkie]

Hi,
  as we dropped icc support (which doesn't support override) I've reverted
the change which is now useless. We will reassess the situation when icc
will fix the other issues we found today.

On Wed, Aug 26, 2015 at 5:13 PM, Alex Rousskov <
rousskov at measurement-factory.com> wrote:

> On 08/26/2015 06:05 AM, Kinkie wrote:
> > Hi,
> >      the attached patch sets up a new autoconf test to detect whether
> > the compiler supports c++11's "override" keyword, and defines a
> > generally-available "OVERRIDE" preprocessor macro which expands to
> > "override" if support is present and nothing if it isn't.
> >
> > This patch is necessary to support icc 13.1.3 which claims to be c++11
> > but doesn't support this keyword.
>
>
> I do not see why we should pollute our code with OVERRIDE screams. If we
> require C++11 support, we should not #define override or any other
> standard and commonly used keywords. If somebody wants to compile with
> icc 13.1.3, give them a command to remove override keywords from sources.
>
> If you disagree, please use low-case letters for that #define. For
> example, squid_override.
>
>
> Thank you,
>
> Alex.
>
>


-- 
    Francesco
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squid-cache.org/pipermail/squid-dev/attachments/20150826/6d1da2fb/attachment.html>