[squid-dev] [PATCH] Coverity-fixes, part 1: EnumIterator

[Kinkie]

I'll answer the other points separately, but

> * the iterator_type being used in static_cast before the typedef _looks_
> very dangerous (even if its fine and works).
>  - I would place typedef up the top in their own protected area to avoid
> a) depending on implicit compiler behaviour and b) future developer
> mistakes/misunderstanding.
>

Sure.


> I dont see the first-user code that we normally require for accepting
> these. I know its coming with a rather big followup, just would be good
> if there was a simple use that could be used as exemplar.
>

I can try to look for one but it'd be completely unrelated to the main
objective of the patch.
Doing that in this patch would basically pull the whole branch in.
If that's fine by you, I'll look for a candidate.

-- 
    Francesco
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squid-cache.org/pipermail/squid-dev/attachments/20150824/d17cd7b0/attachment.html>