[squid-dev] [RFC] deprecatign self_destruct()

[Alex Rousskov]

On 08/24/2015 05:03 AM, Amos Jeffries wrote:
> See <http://bugs.squid-cache.org/show_bug.cgi?id=3693>.
> 
> Its behaviour turns out to be rather nasty, despite a the use it has.
> ConfigParser class provides a destruct() method which correctly outputs
> the Bungled lines when actually relevant during the parse stage.
> 
> I belive all uses of self_destruct() during post-configure validation
> checks are better written as fatal() or fatalf() with an error
> description by the caller.
> 
> So am calling for self_destruct() to start being avoided in all new
> patches and we work towards removing it where code is changed.
> 
>  Any objections?

None from me, at least for the code where ConfigParser::destruct() is as
easily reachable as self_destruct().

Alex.