[squid-dev] find-bad-changes.pl

[Amos Jeffries]

On 22/08/2015 8:03 p.m., Amos Jeffries wrote:
> On 22/08/2015 12:44 p.m., Alex Rousskov wrote:
>> On 08/21/2015 10:47 AM, Kinkie wrote:
>>
>>> This is in fact what I have tried to - sometimes not to the letter,
>>> unfortunately, and I'm sorry for that.
>>
>> FWIW, the attached quick-and-dirty find-bad-changes.pl script detects
>> some offending patch changes, but it is not 100% accurate and is not
>> meant to replace a human developer examining the patch before posting.
>>
> 
> Thank you.
> 

On 24/08/2015 10:03 p.m., Kinkie wrote:
> 
> Would it make sense to add that script to the tree? IMO it does if we want
> to apply it consistently.
> 

Maybe. If it were more accurate and polished.


But keep in mind; we also need a proper coding style validator for
maintenance and commit hooks to reject bad patches, or auto-format.
Either of which affects the usefulness of this type of script and
auditors work requirements long-term.

Amos