[squid-dev] [PATCH] turn FtpServer::EarlyErrorKind into strongly-typed enum

[Kinkie]

Hi,
   In this case it's not needed and it clashes with the (well-reasoned)
idea in the code not to have a default clause in the swtich statement at
FtpServer.cc:559 so that compilers can check that all cases are covered.
Thanks!

On Thu, Aug 20, 2015 at 6:03 PM, Alex Rousskov <
rousskov at measurement-factory.com> wrote:

> On 08/20/2015 06:10 AM, Kinkie wrote:
>
> >   the attached patch turns FtpServer::EarlyErrorKind from a C enum into
> > c++11 strongly-typed enum. The code did not require any change, just a
> > bit of search-and-replace.
>
> Consider adding begin/end markers (for your EnumIteration code) while
> you rewriting/renaming this (or any other) enum.
>
> Alex.
>
>


-- 
    Francesco
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squid-cache.org/pipermail/squid-dev/attachments/20150821/4ea5c5cd/attachment.html>