[squid-dev] bug 4303

[Marcus Kool]

Amos, Christos,

Christos' patch seems not to work for plain 3.5.7 sources.
What do you suggest to try ?   Will there be a snapshot release that is suitable for testing ?

Marcus


On 08/12/2015 11:32 AM, Marcus Kool wrote:
> Amos,
> I tried the patch but several hunks failed.
> It seems that the patch is not compatible with the 3.5.7 release code or I am doing something wrong (see below).
> Marcus
>
> [root at srv018 squid-3.5.7]# patch -b -p0 --dry-run < ../squid-sslbump-patch
> checking file src/acl/Acl.h
> Hunk #1 succeeded at 150 (offset 1 line).
> checking file src/acl/BoolOps.cc
> checking file src/acl/BoolOps.h
> Hunk #1 FAILED at 45.
> 1 out of 1 hunk FAILED
> checking file src/acl/Checklist.cc
> checking file src/acl/Checklist.h
> checking file src/acl/Tree.cc
> Hunk #2 FAILED at 69.
> 1 out of 2 hunks FAILED
> checking file src/acl/Tree.h
> Hunk #1 FAILED at 23.
> 1 out of 1 hunk FAILED
> checking file src/client_side.cc
> Hunk #1 FAILED at 4181.
> Hunk #2 FAILED at 4247.
> 2 out of 2 hunks FAILED
> checking file src/ssl/PeerConnector.cc
> Hunk #1 FAILED at 214.
> 1 out of 1 hunk FAILED
>
>
> On 08/12/2015 10:25 AM, Amos Jeffries wrote:
>> On 13/08/2015 12:48 a.m., Marcus Kool wrote:
>>> yesterday I filed bug 4303 - assertion failed in PeerConnector:743 squid
>>> 3.5.7
>>> I am not sure if it is a duplicate of bug 4259 since that bug
>>> description has almost no info to compare against.
>>>
>>> I enclosed a small fragment of cache.log in the bug report but the debug
>>> setting was ALL,1 93,3 61,9 so cache.log is very large.
>>> In case that you need a larger fragment of cache.log, I can provide it.
>>>
>>
>> Thanks Marcus.
>>
>> I was about to reply to the bug report, but this is better.
>>
>> I suspect this is a case of Squid going the wrong way in ssl_bump
>> interpretation. Specifically the peek action at stage 3.
>>
>> Would you be able to try Christos' patch at the end of the mail here:
>> <http://lists.squid-cache.org/pipermail/squid-dev/2015-August/002981.html>
>>
>>
>> Amos
>>
>> _______________________________________________
>> squid-dev mailing list
>> squid-dev at lists.squid-cache.org
>> http://lists.squid-cache.org/listinfo/squid-dev
>>