[squid-dev] [PATCH] Fix HttpStateData::readReply to retry reads from server

Tsantilas Christos chtsanti at users.sourceforge.net
Thu Apr 9 07:09:37 UTC 2015


Applied to trunk as r14007.

On 04/09/2015 04:07 AM, Amos Jeffries wrote:
> On 9/04/2015 3:12 a.m., Tsantilas Christos wrote:
>> Hi all,
>>
>> This patch fixes HttpStateData::readReply to retry read from server in
>> the case of EINPROGRESS, EAGAIN or similar errors
>>
>> This bug mostly affects SSL bumped connections. The
>> HttpStateData::readReply will not retry read from server in the case of
>> an EINPROGRESS or similar comm errors and the connection will hang,
>> until the timeout handler called.
>>
>> The Comm::ReadNow method, used inside  HttpStateData::readReply, call
>> ignoreErrno function to test if the comm error should be ignored and in
>> this case return Comm::INPROGRESS value.
>> In this case we need to set flags.do_next_read to true to force
>> HttpStateData::maybeReadVirginBody() method retry read.
>>
>> This is a Measurement Factory project
>
> +1. Please apply ASAP.
>
> Amos
>
> _______________________________________________
> squid-dev mailing list
> squid-dev at lists.squid-cache.org
> http://lists.squid-cache.org/listinfo/squid-dev
>



More information about the squid-dev mailing list