[squid-dev] [PATCH] New format code %acl_matched to log the last matched acl

[Amos Jeffries]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 16/11/2014 8:00 a.m., Alfonso Ali wrote:
> Hi,
> 
> I know that it's possible to obtain the last acl that was matched
> by using the correct debug options, but my company have found some
> use cases (mainly related with accounting) where this info could be
> useful without the need of the extra debug information.

What exactly are those use-cases please? Accounting what exactly?

This is important to document as it informs us whether this patch is
only useful for you, or could be useful for others. It may also be
that your use-case is far better served by some other feature or patch
addition.

> 
> Our first approach to the problem used external acls but when the
> load was high we found that some log lines were outputting the
> wrong value,

? sounds like a bug. In which case fixing the bug is the right
approach. Some details on what you found would be appreciated. You can
report through bugzilla to keep this thread clean.

> so we decided to add this new format code.
> 
> I'm sending the patch for your consideration.

Please be aware the named ACL is not valid to be used outside of
Checklist matching sequences. It contains the last ACL to be named
*including* any ACLs tested in figuring out where to log the traffic.
Even if no ACLs are tested determining the log to write to, the name
may be altered at any time by a concurrent request being processed
through some other ACLs.

Amos

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (MingW32)

iQEcBAEBAgAGBQJUaIcHAAoJELJo5wb/XPRjacAIALUgVqQih+RAd4yiaHLe2y/D
NXB8hwymVroRJ3EfFAv52o543QzNhIw5dgt4kjsenPh5e8L8bqeoOPMGI2PL8KGa
WoPfDAPbqQo3NZOMOwFsl6FwHPXYdwsR2Dz/lM7ntko6W+bkW5DASU2Ff/9M3u7q
dh3pMxbocydyW6Zn16tNdcu7lcrHyTKRCZmDHaTRX4TuBTO0eiTAIjKn3fsOhnLq
2XpgJ8LRfa1ioZg7FqGh0WNRSV5yF8njVfGR4NEHD1rDv3UW9ph/hIveTptyqhhX
h8fxEVUlUa18pfJARmRYaPlfRgznSRGobMyb5Hl6ypvLyQxZa+fa9/YOZ8rTzXY=
=CD1Y
-----END PGP SIGNATURE-----