[squid-dev] [PATCH] adapting 100-Continue / A Bug 4067 fix

[Tsantilas Christos]

patch applied to trunk as revno:13697

Regards,
    Christos

On 11/10/2014 12:14 PM, Amos Jeffries wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 10/11/2014 11:06 p.m., Tsantilas Christos wrote:
>> On 11/10/2014 09:36 AM, Amos Jeffries wrote:
>>> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
>>>
>>> On 10/11/2014 10:02 a.m., Tsantilas Christos wrote:
>>>> I am re-posting the patch. There are not huge changes.
>>>
>>> Looking over this in more detail...
>>>
>>> Whats the point of having buildHttpRequest() a separate method
>>> from processRequest() ?
>>
>> It makes the code more readable. It is a private method for use
>> internally by the Http::Server class. I am suggesting to leave it
>> as is. We can fix method name or its documentation.
>>
>>>
>>> The documentation for buildHttpRequest() is wrong, no parsing
>>> takes place there. It is purely post-parse processing of some
>>> parsed HTTP request. ie processParsedRequest() action.
>>
>> The HttpRequest::CreateFromUrlAndMethod still does parsing. But yes
>> we are using pre-parsed informations to build HTTP request object.
>>
>>
>> Is it ok the following documentation for buildHttpRequest?
>>
>> /// Handles parsing results and build an error reply if parsing
>
> I would say "Handles parsing results. May generate then deliver an
> error reply to the client if parsing...".
>
> To make it clear that actual socket I/O might take place.
>
>
>> /// is failed, or parses the url and build the HttpRequest object
>> /// using parsing results. /// Return false if parsing is failed,
>> true otherwise.
>>
>
> Amos
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2.0.22 (MingW32)
>
> iQEcBAEBAgAGBQJUYJAfAAoJELJo5wb/XPRjs58H/3Dya79ljhnSO1H/tuh5aRFI
> vp9cWogMg6OSZT640JMAxsUqL3SkbskUxj8a7aVP6nBW8Xu2VnFJ3PfEIPhq2l09
> CI/wt2erj4iPqabZOhdWxNXBGfrG5t+4qIWZe9ALuXAZsjxAGABWU4Z7tYPn3P7A
> cGKuwbV/3rWGBiXXJgWZuuQeEmD6+QX2j31ErGCJbvzje1acyLRG8Fo8YABiqE6N
> jveeTVJ44ktzSmP2Lf9OneTLp5ktrc/vag0N0zLu6qY3xKxix/QuSBH+7Ff88wX8
> ehctZxnWwnN41brIoZUXIb9Zhqr7GaJ/qYyjFCmJgyCp/bumfHJV7OIld+v5Pck=
> =78Lp
> -----END PGP SIGNATURE-----
> _______________________________________________
> squid-dev mailing list
> squid-dev at lists.squid-cache.org
> http://lists.squid-cache.org/listinfo/squid-dev
>