[squid-dev] [PATCH] adapting 100-Continue / A Bug 4067 fix

[Amos Jeffries]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 10/11/2014 10:02 a.m., Tsantilas Christos wrote:
> I am re-posting the patch. There are not huge changes.

Looking over this in more detail...

Whats the point of having buildHttpRequest() a separate method from
processRequest() ?

The documentation for buildHttpRequest() is wrong, no parsing takes
place there. It is purely post-parse processing of some parsed HTTP
request. ie processParsedRequest() action.

I can sort of see a vague use of something like buildHttpRequest() in
ICAP traffic processing, but not in its current form. The logic there
directly dumps HTTP error messages into the client socket FD. ONly
when that is fixed will the HttpRequest object creation be re-usable code.

+1 whether you inline the two functions again or not.

Amos
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (MingW32)

iQEcBAEBAgAGBQJUYGrlAAoJELJo5wb/XPRjPXgIAL6kboz0n+SF32henbq/iVQx
p6VSr3l/vhyN4Ti1F9e74fzr7IChOp2viZGzxzue/fLIfCYztqPxXWmZ0D4ytL3n
LoM00Q08CZ2TuOvOGD8VZ/6FtBsEyh2CYOrVw17HXfcQlGJgEqLngsKtk3tvDkN2
qDC+NpaAM3Ik1d9fHDR9jghSZn1uWrM+6Tcc50jAZdrOAFH3NKG2m/XyvKHtJBIh
LAyNqlt2ctiGOlyke76+mY3DvqVkTR2/ivwgffEgiCpWlcE4ni1cykID+KYfpKGq
5dM9E9vwyfoWA4hNQJKEYLz1p2TR9RjGLcG9KaEaVyTcCXzGFF6qFnkQZOpd6Fw=
=I66x
-----END PGP SIGNATURE-----