<div dir="ltr">Hi Yuri,<div><br></div><div>I applied the patch against 4.0.8, not 3.5.16. Check my e-mail well well :-)</div><div><br></div><div>Could it be that you have a different code base from the tarballs available for everyone?</div><div><br></div><div><br></div><div class="gmail_extra"><br><div class="gmail_quote">On 8 April 2016 at 20:26, Yuri Voinov <span dir="ltr"><<a href="mailto:yvoinov@gmail.com" target="_blank">yvoinov@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF"><span class="">
<br>
-----BEGIN PGP SIGNED MESSAGE----- <br>
Hash: SHA256 <br>
<br></span>
Note: Codebase for 4.0.x is different with 3.5.x. So, most patches
for 4.x.x series can't be applied onto 3.5.x.<br>
<br>
08.04.16 23:23, Odhiambo Washington пишет:<br>
<span style="white-space:pre-wrap"><span class="">> Hi Yuri,<br>
><br>
> Sorry to be a thorn in the flesh in this one.<br>
><br>
> Which source code were you applying this patch against?<br>
><br>
> I applied this patch on the released squid-4.0.8.tar.xz and
it doesn't apply cleanly for starters... Maybe I am doing it
wrongly? Just doing patch < /path/to/patch<br>
><br>
> <a href="mailto:wash@mail:~/ILI/Squid/4.x/squid-4.0.8$" target="_blank">wash@mail:~/ILI/Squid/4.x/squid-4.0.8$</a> patch <
../squid-4-14633.patch<br>
> Hmm... Looks like a unified diff to me...<br>
> The text leading up to this was:<br>
> --------------------------<br>
> |------------------------------------------------------------<br>
> |revno: 14633<br>
> |revision-id:
<a href="mailto:squid3@treenet.co.nz-20160408073547-xtjco0mpai4lr920" target="_blank">squid3@treenet.co.nz-20160408073547-xtjco0mpai4lr920</a><br>
> |parent:
<a href="mailto:chtsanti@users.sourceforge.net-20160407163610-yl8zzhc08l1ysv5f" target="_blank">chtsanti@users.sourceforge.net-20160407163610-yl8zzhc08l1ysv5f</a><br></span>
> |committer: Amos Jeffries <<a href="mailto:squid3@treenet.co.nz" target="_blank">squid3@treenet.co.nz</a>
<a href="mailto:squid3@treenet.co.nz" target="_blank"><mailto:squid3@treenet.co.nz></a>><div><div class="h5"><br>
> |branch nick: trunk<br>
> |timestamp: Fri 2016-04-08 19:35:47 +1200<br>
> |message:<br>
> | Fix shm_open error message after rev.14625<br>
> |------------------------------------------------------------<br>
> |# Bazaar merge directive format 2 (Bazaar 0.90)<br>
> |# revision_id:
<a href="mailto:squid3@treenet.co.nz-20160408073547-xtjco0mpai4lr920" target="_blank">squid3@treenet.co.nz-20160408073547-xtjco0mpai4lr920</a><br>
> |# target_branch:
<a href="http://bzr.squid-cache.org/bzr/squid3/trunk/" target="_blank">http://bzr.squid-cache.org/bzr/squid3/trunk/</a><br>
> |# testament_sha1: c1983f6601c29e4d03f936e60ecee221a860f932<br>
> |# timestamp: 2016-04-08 07:51:00 +0000<br>
> |# source_branch: <a href="http://bzr.squid-cache.org/bzr/squid3/trunk" target="_blank">http://bzr.squid-cache.org/bzr/squid3/trunk</a><br>
> |# base_revision_id:
<a href="mailto:chtsanti@users.sourceforge.net-20160407163610-%5C" target="_blank">chtsanti@users.sourceforge.net-20160407163610-\</a><br>
> |# yl8zzhc08l1ysv5f<br>
> |#<br>
> |# Begin patch<br>
> |=== modified file 'src/ipc/mem/Segment.cc'<br>
> |--- src/ipc/mem/Segment.cc 2016-04-03 23:41:58 +0000<br>
> |+++ src/ipc/mem/Segment.cc 2016-04-08 07:35:47 +0000<br>
> --------------------------<br>
> Patching file src/ipc/mem/Segment.cc using Plan A...<br>
> Hunk #1 failed at 91.<br>
> Hunk #2 succeeded at 105 (offset -4 lines).<br>
> Hunk #3 succeeded at 121 (offset -4 lines).<br>
> Hunk #4 succeeded at 151 (offset -1 lines).<br>
> 1 out of 4 hunks failed--saving rejects to
src/ipc/mem/Segment.cc.rej<br>
> Hmm... The next patch looks like a unified diff to me...<br>
> The text leading up to this was:<br>
> --------------------------<br>
> |<br>
> |=== modified file 'src/ipc/mem/Segment.h'<br>
> |--- src/ipc/mem/Segment.h 2016-03-24 17:02:25 +0000<br>
> |+++ src/ipc/mem/Segment.h 2016-04-08 07:35:47 +0000<br>
> --------------------------<br>
> Patching file src/ipc/mem/Segment.h using Plan A...<br>
> Hunk #1 succeeded at 53.<br>
> Hmm... Ignoring the trailing garbage.<br>
> done<br>
><br>
><br>
> Then when I compile, the compilation fails as follows (though
without the patch the compilation succeeds):<br>
><br>
> libtool: compile: clang++ -DHAVE_CONFIG_H
-DDEFAULT_STATEDIR=\"/opt/squid-4/var/run/squid\" -I../..
-I../../include -I../../lib -I../../src -I../../include
-I/usr/include -I/usr/include -I../../libltdl -I/usr/include
-I/usr/local/include/libxml2 -I/usr/local/include/libxml2 -Werror
-Qunused-arguments -Wno-deprecated-register -D_REENTRANT -g -O2
-march=native -std=c++11 -I/usr/local/include -MT mem/Pages.lo -MD
-MP -MF mem/.deps/Pages.Tpo -c mem/Pages.cc -fPIC -DPIC -o
mem/.libs/Pages.o<br>
> libtool: compile: clang++ -DHAVE_CONFIG_H
-DDEFAULT_STATEDIR=\"/opt/squid-4/var/run/squid\" -I../..
-I../../include -I../../lib -I../../src -I../../include
-I/usr/include -I/usr/include -I../../libltdl -I/usr/include
-I/usr/local/include/libxml2 -I/usr/local/include/libxml2 -Werror
-Qunused-arguments -Wno-deprecated-register -D_REENTRANT -g -O2
-march=native -std=c++11 -I/usr/local/include -MT mem/Pages.lo -MD
-MP -MF mem/.deps/Pages.Tpo -c mem/Pages.cc -o mem/Pages.o
>/dev/null 2>&1<br>
> depbase=`echo mem/PageStack.lo | sed
's|[^/]*$|.deps/&|;s|\.lo$||'`; /bin/sh ../../libtool
--tag=CXX --mode=compile clang++ -DHAVE_CONFIG_H
-DDEFAULT_STATEDIR=\"/opt/squid-4/var/run/squid\" -I../..
-I../../include -I../../lib -I../../src -I../../include
-I/usr/include -I/usr/include -I../../libltdl -I/usr/include
-I/usr/local/include/libxml2 -I/usr/local/include/libxml2
-Werror -Qunused-arguments -Wno-deprecated-register -D_REENTRANT
-g -O2 -march=native -std=c++11 -I/usr/local/include -MT
mem/PageStack.lo -MD -MP -MF $depbase.Tpo -c -o mem/PageStack.lo
mem/PageStack.cc && mv -f $depbase.Tpo $depbase.Plo<br>
> libtool: compile: clang++ -DHAVE_CONFIG_H
-DDEFAULT_STATEDIR=\"/opt/squid-4/var/run/squid\" -I../..
-I../../include -I../../lib -I../../src -I../../include
-I/usr/include -I/usr/include -I../../libltdl -I/usr/include
-I/usr/local/include/libxml2 -I/usr/local/include/libxml2 -Werror
-Qunused-arguments -Wno-deprecated-register -D_REENTRANT -g -O2
-march=native -std=c++11 -I/usr/local/include -MT mem/PageStack.lo
-MD -MP -MF mem/.deps/PageStack.Tpo -c mem/PageStack.cc -fPIC
-DPIC -o mem/.libs/PageStack.o<br>
> libtool: compile: clang++ -DHAVE_CONFIG_H
-DDEFAULT_STATEDIR=\"/opt/squid-4/var/run/squid\" -I../..
-I../../include -I../../lib -I../../src -I../../include
-I/usr/include -I/usr/include -I../../libltdl -I/usr/include
-I/usr/local/include/libxml2 -I/usr/local/include/libxml2 -Werror
-Qunused-arguments -Wno-deprecated-register -D_REENTRANT -g -O2
-march=native -std=c++11 -I/usr/local/include -MT mem/PageStack.lo
-MD -MP -MF mem/.deps/PageStack.Tpo -c mem/PageStack.cc -o
mem/PageStack.o >/dev/null 2>&1<br>
> depbase=`echo mem/Segment.lo | sed
's|[^/]*$|.deps/&|;s|\.lo$||'`; /bin/sh ../../libtool
--tag=CXX --mode=compile clang++ -DHAVE_CONFIG_H
-DDEFAULT_STATEDIR=\"/opt/squid-4/var/run/squid\" -I../..
-I../../include -I../../lib -I../../src -I../../include
-I/usr/include -I/usr/include -I../../libltdl -I/usr/include
-I/usr/local/include/libxml2 -I/usr/local/include/libxml2
-Werror -Qunused-arguments -Wno-deprecated-register -D_REENTRANT
-g -O2 -march=native -std=c++11 -I/usr/local/include -MT
mem/Segment.lo -MD -MP -MF $depbase.Tpo -c -o mem/Segment.lo
mem/Segment.cc && mv -f $depbase.Tpo $depbase.Plo<br>
> libtool: compile: clang++ -DHAVE_CONFIG_H
-DDEFAULT_STATEDIR=\"/opt/squid-4/var/run/squid\" -I../..
-I../../include -I../../lib -I../../src -I../../include
-I/usr/include -I/usr/include -I../../libltdl -I/usr/include
-I/usr/local/include/libxml2 -I/usr/local/include/libxml2 -Werror
-Qunused-arguments -Wno-deprecated-register -D_REENTRANT -g -O2
-march=native -std=c++11 -I/usr/local/include -MT mem/Segment.lo
-MD -MP -MF mem/.deps/Segment.Tpo -c mem/Segment.cc -fPIC -DPIC
-o mem/.libs/Segment.o<br>
> mem/Segment.cc:96:22: error: too few arguments to function
call, single argument 'err' was not specified<br>
> if (!createFresh() && errno == EEXIST) {<br>
> ~~~~~~~~~~~ ^<br>
> ../../src/ipc/mem/Segment.h:56:5: note: 'createFresh'
declared here<br>
> bool createFresh(int &err);<br>
> ^<br>
> mem/Segment.cc:98:21: error: too few arguments to function
call, single argument 'err' was not specified<br>
> createFresh();<br>
> ~~~~~~~~~~~ ^<br>
> ../../src/ipc/mem/Segment.h:56:5: note: 'createFresh'
declared here<br>
> bool createFresh(int &err);<br>
> ^<br>
> mem/Segment.cc:108:9: error: use of undeclared identifier
'xerrno'<br>
> xerrno = errno;<br>
> ^<br>
> mem/Segment.cc:110:66: error: use of undeclared identifier
'xerrno'<br>
> debugs(54, 5, "ftruncate " << theName <<
": " << xstrerr(xerrno));<br>
>
^<br>
> ../../src/Debug.h:107:21: note: expanded from macro 'debugs'<br>
> _dbo << CONTENT; \<br>
> ^<br>
> mem/Segment.cc:112:45: error: use of undeclared identifier
'xerrno'<br>
> theName.termedBuf(), xstrerr(xerrno));<br>
> ^<br>
> 5 errors generated.<br>
> *** Error code 1<br>
><br>
> Stop.<br>
> make[3]: stopped in
/usr/home/wash/ILI/Squid/4.x/squid-4.0.8/src/ipc<br>
> *** Error code 1<br>
><br>
> Stop.<br>
> make[2]: stopped in
/usr/home/wash/ILI/Squid/4.x/squid-4.0.8/src<br>
> *** Error code 1<br>
><br>
> Stop.<br>
> make[1]: stopped in
/usr/home/wash/ILI/Squid/4.x/squid-4.0.8/src<br>
> *** Error code 1<br>
><br>
> Stop.<br>
> make: stopped in /usr/home/wash/ILI/Squid/4.x/squid-4.0.8<br>
><br>
><br>
> Okay, I know I am being a bug here myself since I am focused
on 3.5 now more than 4.x but I also like giving the little
feedback I can from these FreeBSD servers I have:-)<br>
><br>
><br>
><br>
><br>
><br></div></div><span class="">
> On 8 April 2016 at 17:19, Yuri Voinov <<a href="mailto:yvoinov@gmail.com" target="_blank">yvoinov@gmail.com</a>
<a href="mailto:yvoinov@gmail.com" target="_blank"><mailto:yvoinov@gmail.com></a>> wrote:<br>
><br>
><br>
> Seems fixed.<br>
><br>
> <a href="http://bugs.squid-cache.org/show_bug.cgi?id=4486#c2" target="_blank">http://bugs.squid-cache.org/show_bug.cgi?id=4486#c2</a><br>
><br>
> 08.04.16 18:05, Amos Jeffries пишет:<br>
> > On 8/04/2016 10:28 p.m., Odhiambo Washington wrote:<br>
> >> Hello Yuri,<br>
> >><br>
> >> Thanks, but this patch is for squid-4.0.8, right??<br>
> >><br>
><br>
> > Yes the patch in that bug report is specific to the
latest 4.0 snapshot,<br>
> > which Yuri is running.<br>
><br>
> > As Alex mentioned the errno usage in Squid was a bit
wrong. The latest<br>
> > 4.0 have a patch to fix that, which is causing Yuri's
problem. Your 3.5<br>
> > issue may or may not be related. But we wont know until
after Yuri<br>
> > applies that patch and checks the results.<br>
><br>
> > Amos<br>
><br>
> > _______________________________________________<br>
> > squid-users mailing list<br></span>
> > <a href="mailto:squid-users@lists.squid-cache.org" target="_blank">squid-users@lists.squid-cache.org</a>
<a href="mailto:squid-users@lists.squid-cache.org" target="_blank"><mailto:squid-users@lists.squid-cache.org></a><br>
> > <a href="http://lists.squid-cache.org/listinfo/squid-users" target="_blank">http://lists.squid-cache.org/listinfo/squid-users</a><br>
><br>
><br>
><br>
> _______________________________________________<br>
> squid-users mailing list<br>
> <a href="mailto:squid-users@lists.squid-cache.org" target="_blank">squid-users@lists.squid-cache.org</a>
<a href="mailto:squid-users@lists.squid-cache.org" target="_blank"><mailto:squid-users@lists.squid-cache.org></a><span class=""><br>
> <a href="http://lists.squid-cache.org/listinfo/squid-users" target="_blank">http://lists.squid-cache.org/listinfo/squid-users</a><br>
><br>
><br>
><br>
><br>
> -- <br>
> Best regards,<br>
> Odhiambo WASHINGTON,<br>
> Nairobi,KE<br>
> +254 7 3200 0004/+254 7 2274 3223<br>
> "Oh, the cruft."</span></span><br><span class="">
<br>
-----BEGIN PGP SIGNATURE-----
<br>
Version: GnuPG v2
<br>
<br></span>
iQEcBAEBCAAGBQJXB+nGAAoJENNXIZxhPexGPbwH/2vQ0DotjjMQ8rtS+bUYri27
<br>
qtF91SKYcxUVlpMYqZ4WkCY4J6f9R0s2lyejUM2UxXaPK+Y5Sule4OSzUzjUt/TH
<br>
bmHWlfEQ4m/RP8fcAI9LVLfrJauT7MagnT6DsE/Yz3CAKFGJ5E1TnGy7ppzbVA0K
<br>
mEqlspld/ZDnFAJTCz616BKGfmZIXISd7KxxB9V4uOgLjVKwSydczDSse4xqA+GQ
<br>
MFW4MHf3RtS7TAU6CwSdykGrTGGlO8JE+c0E2MPcZs+gYjwoE2qFjv/U8PKC1482
<br>
AZZxJ05+Ew5c/VN7mJpjSRavC1yeBy0l0ReiZlKpcuno2cuXIp6qeZ7OjxIj7oc=
<br>
=9dU1
<br>
-----END PGP SIGNATURE-----
<br>
<br>
</div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr"><div>Best regards,<br>Odhiambo WASHINGTON,<br>Nairobi,KE<br>+254 7 3200 0004/+254 7 2274 3223<br>"<span style="font-size:12.8px">Oh, the cruft.</span><span style="font-size:12.8px">"</span></div></div></div>
</div></div>