<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type content="text/html; charset=us-ascii"><meta name=Generator content="Microsoft Word 15 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
mso-fareast-language:EN-US;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0cm;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";}
p.MsoListParagraph, li.MsoListParagraph, div.MsoListParagraph
{mso-style-priority:34;
margin-top:0cm;
margin-right:0cm;
margin-bottom:0cm;
margin-left:36.0pt;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
mso-fareast-language:EN-US;}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:"Courier New";
mso-fareast-language:EN-CA;}
span.EmailStyle20
{mso-style-type:personal-compose;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;
font-family:"Calibri",sans-serif;
mso-fareast-language:EN-US;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body lang=EN-CA link="#0563C1" vlink="#954F72"><div class=WordSection1><p class=MsoNormal>I’m encountering this same issue in Squid-3.5.3 <o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal><span style='font-size:10.0pt;font-family:"Courier New";color:black;mso-fareast-language:EN-CA'>> Changed to:<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt;font-family:"Courier New";color:black;mso-fareast-language:EN-CA'>><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt;font-family:"Courier New";color:black;mso-fareast-language:EN-CA'>> inline void setServerBump(Ssl::ServerBump *srvBump) {<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt;font-family:"Courier New";color:black;mso-fareast-language:EN-CA'>> if (!sslServerBump)<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt;font-family:"Courier New";color:black;mso-fareast-language:EN-CA'>> sslServerBump = srvBump;<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt;font-family:"Courier New";color:black;mso-fareast-language:EN-CA'>> else<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt;font-family:"Courier New";color:black;mso-fareast-language:EN-CA'>> assert(sslServerBump = srvBump);<o:p></o:p></span></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>Just FYI, from a glance this would leak an Ssl::ServerBump every time it hit that assert, which at least in my case would be quite often.<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>What I ended up doing, which could be completely wrong for the behaviour, but it seems to avoid the crashes, was add a function clearServerBump(), and use that in setServerBump to clean up the old sslServerBump (as in the header file it is only a forward declaration of the class):<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>client_side.h<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal> void clearServerBump();<o:p></o:p></p><p class=MsoNormal> inline void setServerBump(Ssl::ServerBump *srvBump) {<o:p></o:p></p><p class=MsoNormal> if (sslServerBump) {<o:p></o:p></p><p class=MsoNormal> if (sslServerBump != srvBump) {<o:p></o:p></p><p class=MsoNormal> clearServerBump();<o:p></o:p></p><p class=MsoNormal> } else {<o:p></o:p></p><p class=MsoNormal> return;<o:p></o:p></p><p class=MsoNormal> }<o:p></o:p></p><p class=MsoNormal> }<o:p></o:p></p><p class=MsoNormal> sslServerBump = srvBump;<o:p></o:p></p><p class=MsoNormal> }<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>client_side.cc<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>void ConnStateData::clearServerBump() {<o:p></o:p></p><p class=MsoNormal> delete sslServerBump;<o:p></o:p></p><p class=MsoNormal> sslServerBump = 0;<o:p></o:p></p><p class=MsoNormal>}<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>This could entirely have unintended side effects as I am not very familiar with how sslbumping is implemented, and the intended lifetime of the objects as relates to the client requests, but if you’re still using the workaround you posted I thought you should be aware that you would be leaking memory and provide you with an equivalent “solution” which does not leak memory in the same way.<o:p></o:p></p></div></body></html>