[squid-users] Squid 3.5.16 and vary loop objects (bug ?)

[Amos Jeffries]

On 6/04/2016 7:47 p.m., FredB wrote:
> 
>>
>> As I'm currently updating too: is this a bug or have I only to clear
>> the
>> old cache directories to prevent these error messages?
>>
> 
> As far as I know, no, I tried

I think you guys misundersood what I was asking about.

So lets try this again...

Can somebody check whether applying the attached patch _and_ clearing
the cache does anything useful?
(should apply with "patch -p0" to squid-3.5.16)

If the answer is yes, then it can be used while I work on a better fix
that wont need clearing the cache.

Amos

-------------- next part --------------
=== modified file 'src/store_swapmeta.cc'
--- src/store_swapmeta.cc	2016-04-01 06:15:31 +0000
+++ src/store_swapmeta.cc	2016-04-06 12:03:43 +0000
@@ -89,9 +89,7 @@
     SBuf vary(e->mem_obj->vary_headers);
 
     if (!vary.isEmpty()) {
-        // TODO: do we still need +1 here? StoreMetaVary::checkConsistency
-        //       no longer relies on nul-termination, but other things might.
-        t = StoreMeta::Factory(STORE_META_VARY_HEADERS, vary.length() + 1, vary.c_str());
+        t = StoreMeta::Factory(STORE_META_VARY_HEADERS, vary.length(), vary.c_str());
 
         if (!t) {
             storeSwapTLVFree(TLV);