[squid-users] problem with ntlm_smb_lm_auth helper

[Amos Jeffries]

On 8/09/2015 1:17 a.m., Emmanuel Garette wrote:
> Le 07/09/2015 14:01, Amos Jeffries a écrit :
>> On 7/09/2015 10:23 p.m., Emmanuel Garette wrote:
>>> ntlmssp: bad ascii: fffffffb
>>> ntlmssp: bad ascii: ffffff99
>>> ntlmssp: bad ascii: ffffffdc
>>> ntlmssp: bad ascii: fffffff3
>>> ntlmssp: bad ascii: 0000
>>> ntlmssp: bad ascii: ffffffdd
>>> ntlmssp: bad ascii: fffffffa
>>> ntlmssp: bad ascii: ffffff8f
>>> ntlmssp: bad ascii: ffffffa6
>>> ntlmssp: bad ascii: 0017
>>> ntlmssp: bad ascii: ffffffca
>>> ntlmssp: bad ascii: ffffff97
>>> ntlmssp: bad ascii: ffffffeb
>>> ntlmssp: bad ascii: ffffffd2
>>> ntlmssp: bad ascii: fffffffc
>>> ntlmssp: bad ascii: ffffffda
>>> ntlmssp: bad ascii: ffffffa9
>>> ntlmssp: bad ascii: ffffffdd
>>> ntlm_smb_lm_auth.cc(277): pid=5278 :Empty LM pass detection: user:
>>> 'ADMIN', ours:'(E�
>>>                                                                                     
>>> �p�����(jw�B�����.Q�7��h(�', his: '�2��Z�' (length: 24)
>>> ntlmssp: bad ascii: ffffffdd
>>> ntlmssp: bad ascii: 0018
>>> ntlmssp: bad ascii: ffffffb2
>>> ntlmssp: bad ascii: 001e
>>> ntlmssp: bad ascii: ffffff9b
>>> ntlmssp: bad ascii: fffffffd
>>> ntlmssp: bad ascii: 007f
>>> ntlmssp: bad ascii: 0010
>>> ntlmssp: bad ascii: ffffff89
>>> ntlmssp: bad ascii: ffffff8c
>>> ntlmssp: bad ascii: ffffff85
>>> ntlmssp: bad ascii: ffffffa0
>>> ntlmssp: bad ascii: ffffffac
>>> ntlmssp: bad ascii: ffffffb8
>>> ntlmssp: bad ascii: 0000
>>> ntlm_smb_lm_auth.cc(288): pid=5278 :Empty NT pass detection: user:
>>> 'ADMIN', ours:'�����a����A
>>>                                                                                              
>>> ��2��', his: '�g[�S�P�Z<�^�:���<�M' (length: 24)
>>> ntlm_smb_lm_auth.cc(299): pid=5278 :checking domain: 'DOMPEDAGO', user:
>>> 'ADMIN', pass='�2��Z�'
>>>
>> Ah! fetch_string should not even have been used at all on these encoded
>> blobs. They are not strings. That appears to be the problem.
>>
>> Please try the attached patch.
>> (It should apply on squid-3.3 with patch -p0 ).
> Seems to be ok for me. Thanks for your fast reply.
> 
> Need I open a bug in bugzilla ?
> 

No need. I think this may be one of the existing ones about this helper.
Thanks for the feedback it should be applied to the current versions
shortly.

Amos