[squid-users] Squid: Small packets and low performance between squid and icap

Amos Jeffries squid3 at treenet.co.nz
Thu Nov 5 15:14:26 UTC 2015


On 5/11/2015 10:41 p.m., Prashanth Prabhu wrote:
> Hello Amos,
> 
> Thanks for the quick response.
> 
> I failed to mention that I am on 3.5.1. And, readSomeData() is already "fixed":

Bug 4353 exists because the initial fix for 4206 was not enough to fully
remove the behaviour. Sometimes yes, sometimes no.

Only the nasty hack of allocating buffers twice and throwing one away
unused seems to work fully so far. That is the patch in 4353.


> ----
> void
> ConnStateData::readSomeData()
> {
>     if (reading())
>         return;
> 
>     debugs(33, 4, HERE << clientConnection << ": reading request...");
> 
>     if (!in.maybeMakeSpaceAvailable())
>         return;
> 
>     typedef CommCbMemFunT<ConnStateData, CommIoCbParams> Dialer;
>     reader = JobCallback(33, 5, Dialer, this, ConnStateData::clientReadRequest);
>     Comm::Read(clientConnection, reader);
> }
> ----
> 
> I am planning to try the "patch client_side.cc to call
> maybeMakeSpaceAvailable()" from #4206. Anything else, I should try?

The patch from 4353.

And also upgrading to 3.5.11 unless that was a typo in the version
number *.1 above.

Amos



More information about the squid-users mailing list