<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Hello,<br>
<br>
This patch fixes valgrind-discovered trunk errors.<br>
<br>
<meta http-equiv="content-type" content="text/html; charset=utf-8">
During start-up, Valgrind reported many errors with a similar
message:<br>
"Use of uninitialised value of size 8...". These errors were caused
by<br>
HttpRequestMethod& parameter during private key generation:<br>
it was used as a raw void* memory there. HttpRequestMethod is a
non-POD<br>
type and has some "padding" bytes, which are not initialized by the
constructor.<br>
<br>
The patch simplifies private key generation by using a counter for
this,<br>
which is sufficient to create a unique key within a single Squid
process.<br>
Except fixing Valgrind errors, this solution saves many CPU cycles
wasted on<br>
generating MD5 hashes just to "guarantee" uniqueness within a single
process.<br>
<br>
Regards,
<br>
Eduard.<br>
</body>
</html>