[squid-dev] [PATCH] Adds support for --long-acl-options

Amos Jeffries squid3 at treenet.co.nz
Wed May 31 04:58:48 UTC 2017


On 25/05/17 02:39, Alex Rousskov wrote:
> On 05/24/2017 02:31 AM, Christos Tsantilas wrote:
>> Adds support for --long-acl-options
> s/Adds/Add/ or
> s/Adds support for/Support/.
>
>
>> This patch adds support for --long-acl-options. The old single-letter
> The first sentence in the second paragraph can be removed as it
> duplicates the first paragraph.
>
> The above are minor polishing touches to the proposed commit message
> which can be accommodated during commit. I support committing these
> changes, but I have not reviewed the very latest version and wrote parts
> of an earlier version.
>
>
> FYI: Factory is almost done with a patch that actually adds --long
> options to the server_name ACL (and that motivated this refactoring
> work). We decided to split the two sets of changes to ease review of
> that second/upcoming patch.

That has worked quite well. The other patch was quite easily reviewed.

This one however is still a pain. I would really like to get my head 
around this change before it goes in, but I will not have time to even 
read it all within the next 7 days. Please hold committing this until I 
can followup. Thanks.

Amos



More information about the squid-dev mailing list