[squid-dev] [PATCH] Honor peer timeouts when forwarding CONNECTs
rousskov at measurement-factory.com
Thu Mar 16 17:39:41 UTC 2017
On 03/16/2017 01:15 AM, Amos Jeffries wrote:
> * "start" is an action name and we use it (almost?) exclusively for Job
> initiation. By comparison "started" means/implies more clearly a state
> or time point. The Tunnel member stores a time point.
> - IMO both are bad, but "started" is better than "start". Better still
> would be a name that actually describes *what* has been start(ed).
IIRC, I renamed started to start. I did that because start can be a noun
while started is a past tense verb, and we use such verbs for boolean
flags indicating past occurrence of some event.
> I do not mind renaming it, e.g., into 'creationTime'.
startTime would probably work better mid-term. And when TunnelStateData
becomes a proper job, managing its own start() time, we can rename this
to start_ to avoid a type-like suffix.
On the other hand, whatever you two can agree on regarding this name
will work. I do not plan to post about this minor issue again. I only
posted because the current name was probably not Eduard's fault.
More information about the squid-dev