[squid-dev] Fwd: [PATCH] for loops modernization
rousskov at measurement-factory.com
Wed Mar 15 14:40:14 UTC 2017
On 03/15/2017 08:17 AM, Amos Jeffries wrote:
> That said, there are points in the lifecycle which are more friendly to
> bg changes. The next one I expect these C++11 changes can even have a
> chance is after 3.5 ceases to be a supported version.
I agree, especially if "supported" includes "we still have to do a lot
of backporting even if the Squid Project itself no longer does that".
> Theoretically range-for loops should allow multi-threaded CPU to run
> those loops a bit faster. If that can be demonstrated using a tool like
> polygraph you have a good argument for a patch containing that change to
> go in as a pure performance change.
I may agree with the second/non-theoretical part: If changing a loop
makes Squid noticeably faster, then it is a valid reason for the change.
IIRC, some of the changes belong to the non-critical performance paths,
but we might be willing to overlook that if critical path performance is
More information about the squid-dev