[squid-dev] [PATCH] for loops modernization

Alex Rousskov rousskov at measurement-factory.com
Sun Mar 12 15:31:34 UTC 2017

On 03/12/2017 07:45 AM, khaled belhout wrote:

> this patch modernize for loops using c++11 Range-based for loop

Please use "const auto" where possible and avoid using "i" for naming
the current iteration object.

I am curious why did you decide to change all these loops? How did you
select the loops to change? Normally, we avoid wide-spread polishing
touches to minimize the price developers working with older code have to
pay when porting back various bug fixes and features. I am trying to
decide whether the advantages of changing these loops outweigh those
costs in this case.

Thank you,


More information about the squid-dev mailing list