[squid-dev] [PATCH] Case-insensitive URI schemes
rousskov at measurement-factory.com
Fri Mar 3 23:21:20 UTC 2017
On 03/03/2017 08:30 AM, Eduard Bagdasaryan wrote:
> Any more suggestions/remarks here before this patch can be applied?
Just one: The patch breaks "make check" because some test cases use URI
schemes and, hence, require the new AnyP::UriScheme::Init() call. [I
cannot wait when we finally automate these mechanical checks but
thankfully we are making good progress towards that automation now.]
I fixed "make check" and committed to v5 (r15088).
> On 07.02.2017 18:10, Eduard Bagdasaryan wrote:
>> Checked that it is ok to move AnyP::UriScheme::Init() as
>> you suggested. Re-attached the patch (v5 r15037).
>> On 02.02.2017 22:12, Alex Rousskov wrote:
>> > We should avoid this code duplication [...]
>> > However, please check whether we can move the
>> > call up, to place it above storeFsInit().
>> > Both of the above changes can be done during commit.
>> squid-dev mailing list
>> squid-dev at lists.squid-cache.org
> squid-dev mailing list
> squid-dev at lists.squid-cache.org
More information about the squid-dev