[squid-dev] [PATCH] Memory overlap Valgrind-reported errors

Amos Jeffries squid3 at treenet.co.nz
Sun Jan 15 17:37:32 UTC 2017


On 16/01/2017 5:15 a.m., Eduard Bagdasaryan wrote:
> Fixed "Source and destination overlap in memcpy" Valgrind errors.
> 
> Before this patch, source and destination arguments in
> log_quoted_string() could point to the same static memory area, causing
> multiple Valgrind-reported errors. Fixed by creating another buffer for
> storing the quoted-processed output string. The buffer size should be
> enough to hold all processed escape sequences.
> 

Ouch. Thanks for finding this.

+1 and Applied to v5 as rev.15010

Amos



More information about the squid-dev mailing list