[squid-dev] [PATCH] remove ip/Qos.cci

[Amos Jeffries]

On 2017-01-08 07:07, Alex Rousskov wrote:
> On 01/07/2017 04:46 AM, Amos Jeffries wrote:
>> This patch removes ip/Qos.cci file moving its content to 
>> ip/QosConfig.cc.
>> 
>> Also, move the stub file to src/tests/stub_libip.cc and update to use
>> tests/STUB.h interface.
> 
> 
> 
>> +bool
>> +Ip::Qos::Config::isHitTosActive() const
>> +{
>> +    return (tosLocalHit || tosSiblingHit || tosParentHit || tosMiss 
>> || preserveMissTos);
>> +}
>> +
>> +bool
>> +Ip::Qos::Config::isHitNfmarkActive() const
>> +{
>> +    return (markLocalHit || markSiblingHit || markParentHit || 
>> markMiss || preserveMissMark);
>> +}
> 
> If possible, please inline the above methods because, AFAICT, they are
> quick test methods with no external dependencies.
> 
> 
>> +++ src/ip/QosConfig.cc	2017-01-07 08:02:59 +0000
>> @@ -7,7 +7,6 @@
>>   */
>> 
>>  #include "squid.h"
>> -
>>  #include "acl/Gadgets.h"
>>  #include "cache_cf.h"
> 
> An out-of-scope change?
> 
> 
> Please commit when you are comfortable with the code.
> 
> 

Applied as rev.15000. , and fixed two scope errors found while testing 
the stub.

Amos