[squid-dev] [PATCH] Incorrect logging of request size

[Alex Rousskov]

On 09/13/2016 10:02 AM, Amos Jeffries wrote:
> On 14/09/2016 2:52 a.m., Alex Rousskov wrote:
>>> http::>h 
>>> To-be-adapted HTTP message headers sent by Squid to
>>> the ICAP service (HTTP request headers in REQMOD; HTTP
>>> response headers in RESPMOD). Please note that Squid
>>> currently does not support logging of HTTP response
>>> headers in RESPMOD for this format code.

>> I will clarify that when committing:
>>
>> http::>h   To-be-adapted HTTP message headers sent by Squid to the ICAP
>> service (i.e., HTTP request headers in REQMOD or HTTP response headers
>> in RESPMOD). However, Squid cannot currently log HTTP response headers
>> sent to the ICAP service (i.e., %http::>h will expand to "-" for RESPMOD
>> transactions).
>>
>> Does that sound better?


> Better, but I think remove the words "or HTTP response headers in
> RESPMOD" from that first statement. The second sentence now explains the
> RESPMOD clearly all by itself.


Committed to trunk (r14838) with the following text:

> http::>h
> To-be-adapted HTTP message headers sent by Squid to
> the ICAP service. For REQMOD transactions, these are
> HTTP request headers. For RESPMOD, these are HTTP
> response headers, but Squid currently cannot log them
> (i.e., %http::>h will expand to "-" for RESPMOD).


Thank you,

Alex.