[squid-dev] Fix If-None-Match processing and related bug 4169

Garri Djavadyan garryd at comnet.uz
Tue Nov 29 12:47:21 UTC 2016


On Tue, 2016-11-29 at 14:51 +0500, Garri Djavadyan wrote:
> Hello,
> 
> Please review the attached patch prepared for r14958, it fixes the
> If-
> None-Match processing (incorrect logging [1]) and the bug [2] report
> 4169 depending on the incorrect (IMO) behavior.
> 
> An If-None-Match request for a non-matched (ETag) but cached object
> should be processed as normal HIT.
> 
> [1] http://lists.squid-cache.org/pipermail/squid-users/2016-November/
> 01
> 3483.html
> [2] http://bugs.squid-cache.org/show_bug.cgi?id=4169
> 
> Thanks.
> 
> Garri

I've attached second version of the patch. In the first version I
removed strings (not related to the fix) which mark a request as non-
IMS, because I thought the same request could not
enter processConditional twice and the removed actions are redundant.
Now I'm not sure about it.

Garri
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix_if-none-match_v2.patch
Type: text/x-patch
Size: 466 bytes
Desc: not available
URL: <http://lists.squid-cache.org/pipermail/squid-dev/attachments/20161129/028e9f22/attachment.bin>


More information about the squid-dev mailing list