[squid-dev] [PATCH] Fixed Write.cc:41 "!ccb->active()" assertion

[Amos Jeffries]

On 16/11/2016 12:58 a.m., Christos Tsantilas wrote:
> Hi all,
>  I applied the patch as r14945 with an r14946 fix.
> 
> Unfortunately while I was testing the Squid-3.5 variant of the patch I
> found a bug:
>  When the Http::One::Server::writeControlMsgAndCall fails to write the
> control message, schedules a Comm::Write callback using just a
> ScheduleCallHere command.
> The callback called without the CommIoCbParams details and squid is
> crashes.
> 
> There are two ways to fix this issue.
>   1) complete the missing CommIoCbParams details inside
> writeControlMsgAndCall
>   2) Make the ConnStateData::writeControlMsgAndCall to return false on
> failures and allow caller handle the failure.
> 
> This patch implements the (2) as I believe it is the better option.
> 
> My apologies for the buggy patch.
> 

Now that the method wroteControlMsgOK() is needing to be called in
not-OK situations I think it should have a different name.
 Perhapse doneWithControlMsg() ?

Amos