[squid-dev] [PATCH] Rework acl/RegexData optimization to use SBufList
gkinkie at gmail.com
Mon Nov 14 10:49:07 UTC 2016
On Mon, Nov 14, 2016 at 5:36 AM, Alex Rousskov
<rousskov at measurement-factory.com> wrote:
> On 11/13/2016 10:15 PM, Amos Jeffries wrote:
>> I think we should accumulate into two SBufList instead, one for -i and
>> one for +i instead of switching back and forth with potentially lots of
>> little patterns.
> Would not forcing regexes into two different groups change the regex
> evaluation order and, hence, make it more difficult for some admins to
> optimize their regexes by placing frequently matching regexes earlier?
> I am still not quite sure what problem we are trying to solve exactly
> here, but allowing admins to control exact regex evaluation order seems
> important [for some admins].
Then these admins should not optimize, as the compiled regex' FSM
guarantees the same results but not necessarily evaluation order.
And IMO mixing insensitive and sensitive regexes is bad practice which
I would advise against in the documentation.
More information about the squid-dev