[squid-dev] [PATCH] Rework acl/RegexData optimization to use SBufList

Amos Jeffries squid3 at treenet.co.nz
Mon Nov 14 06:02:53 UTC 2016


On 14/11/2016 6:36 p.m., Alex Rousskov wrote:
> On 11/13/2016 10:15 PM, Amos Jeffries wrote:
> 
>> I think we should accumulate into two SBufList instead, one for -i and
>> one for +i instead of switching back and forth with potentially lots of
>> little patterns.
> 
> Would not forcing regexes into two different groups change the regex
> evaluation order and, hence, make it more difficult for some admins to
> optimize their regexes by placing frequently matching regexes earlier?
> 
> I am still not quite sure what problem we are trying to solve exactly
> here, but allowing admins to control exact regex evaluation order seems
> important [for some admins].

Good point.

AFAIK the goal is twofold;

1) removing wordlist usage.

 It gets replaced with SBufList.

2) improved performance.

 One of the often raised reasons for people still using re-writer
helpers is that Squid regex take so long to reconfigure when big (MB)
lists are used.

Amos



More information about the squid-dev mailing list